Skip to content

Adds missing getters for some of the new datasource fields #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shinchris merged 1 commit into from
Oct 21, 2020
Merged

Adds missing getters for some of the new datasource fields #708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tableauserverclient/models/datasource_item.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,10 @@ def encrypt_extracts(self):
def encrypt_extracts(self, value):
self._encrypt_extracts = value

@property
def has_extracts(self):
return self._has_extracts

@property
def id(self):
return self._id
Expand Down Expand Up @@ -128,6 +132,10 @@ def use_remote_query_agent(self):
def use_remote_query_agent(self, value):
self._use_remote_query_agent = value

@property
def webpage_url(self):
return self._webpage_url

def _set_connections(self, connections):
self._connections = connections

Expand Down
12 changes: 6 additions & 6 deletions test/test_datasource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@ def test_get(self):
self.assertEqual('SampleDS', all_datasources[0].name)
self.assertEqual('ee8c6e70-43b6-11e6-af4f-f7b0d8e20760', all_datasources[0].project_id)
self.assertEqual('5de011f8-5aa9-4d5b-b991-f462c8dd6bb7', all_datasources[0].owner_id)
self.assertEqual('https://web.com', all_datasources[0]._webpage_url)
self.assertEqual('https://web.com', all_datasources[0].webpage_url)
self.assertFalse(all_datasources[0].encrypt_extracts)
self.assertTrue(all_datasources[0]._has_extracts)
self.assertFalse(all_datasources[0]._use_remote_query_agent)
self.assertTrue(all_datasources[0].has_extracts)
self.assertFalse(all_datasources[0].use_remote_query_agent)

self.assertEqual('9dbd2263-16b5-46e1-9c43-a76bb8ab65fb', all_datasources[1].id)
self.assertEqual('dataengine', all_datasources[1].datasource_type)
Expand All @@ -62,10 +62,10 @@ def test_get(self):
self.assertEqual('ee8c6e70-43b6-11e6-af4f-f7b0d8e20760', all_datasources[1].project_id)
self.assertEqual('5de011f8-5aa9-4d5b-b991-f462c8dd6bb7', all_datasources[1].owner_id)
self.assertEqual(set(['world', 'indicators', 'sample']), all_datasources[1].tags)
self.assertEqual('https://page.com', all_datasources[1]._webpage_url)
self.assertEqual('https://page.com', all_datasources[1].webpage_url)
self.assertTrue(all_datasources[1].encrypt_extracts)
self.assertFalse(all_datasources[1]._has_extracts)
self.assertTrue(all_datasources[1]._use_remote_query_agent)
self.assertFalse(all_datasources[1].has_extracts)
self.assertTrue(all_datasources[1].use_remote_query_agent)

def test_get_before_signin(self):
self.server._auth_token = None
Expand Down