Improves login sample #652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shinchris
commented
Jul 22, 2020
shinchris
commented
- Changed the default sitename argument to be an empty string - consistent with the model objects
- Added more print statements
t8y8
approved these changes
Jul 22, 2020
shinchris
pushed a commit
that referenced
this pull request
Aug 14, 2020
* Fixes login sample to pass in sitename for username/password auth (cherry picked from commit 4cbd800) * Fixes default sitename in login sample and adds more print statements (#652) (cherry picked from commit ccbbc49) * Updates changelog with patch notes * Added webpage_url to workbooks * removed vscode files * Update workbook_item.py Removing whitespace * Update test_workbook.py Removing cells * Update test_workbook.py Removing whitespace * Update workbook_get_by_id.xml Adding webpage url * Create notes property from XML response (#571) Create notes property from XML response Co-authored-by: Jordan Woods <[email protected]> * Minor edits and cleanup * Rename a duplicate test method so they all run * Cleanup test comments and descriptions, no functional changes * Add support for Python 3.8 Only test_publish_with_hidden_view() needed changes because the order of attributes in the XML request body were swapped for some reason in 3.8 compared to prior Pythons. Co-authored-by: Chris Shin <[email protected]> Co-authored-by: Rickey Shideler <[email protected]> Co-authored-by: jorwoods <[email protected]> Co-authored-by: Jordan Woods <[email protected]> Co-authored-by: Brian Cantoni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.