Skip to content

Conversation

@shinchris
Copy link
Contributor

Default permissions urls for update and delete were missing an 's' after the content types. Also noticed that the update permission methods weren't returning the response from server, while the delete methods were unnecessarily returning something.

Changes:

  • Corrected URLs for update and delete default permissions by appending an s to the content type
  • Removed return statements for the delete methods
  • Added return statements for the update methods
  • Fixed delete default permissions test and added a update default permissions test

@shinchris shinchris requested a review from t8y8 April 27, 2020 17:15
@shinchris
Copy link
Contributor Author

I'm also adding some samples. Will push it as soon as it's done.
Since we don't have docs yet, the samples should hopefully help in the meantime.

Copy link
Collaborator

@t8y8 t8y8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you verify it runs on a real server internally (one with Catalog enabled?) -- I'm 99% sure I did back in the day but apparently I missed something.

@shinchris shinchris merged commit b4a1aeb into development May 1, 2020
@shinchris shinchris deleted the default_permissions branch May 1, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants