Skip to content

Conversation

@guodah
Copy link
Contributor

@guodah guodah commented Mar 1, 2020

The feature "Materialized Views" has been replaced with "Data Acceleration" in the server code, including the rest api schema and urls. This PR is to make the name change in the client side.

@shinchris
Copy link
Contributor

The changes themselves look good 😄
My only concern is that the sample might be too complex to be considered a useful sample for our users. Samples should capture specific and frequent scenarios that should be easy for a new user to refer to for examples of using the library.
Would it be possible to break this sample into specific scenarios? Doesn't have to be part of this MR, though, since this is for 2020.2.

@guodah
Copy link
Contributor Author

guodah commented Mar 3, 2020

Thanks for the speedy review! Our team wants to provide users with a "comprehensive" script to use our feature with different options as our feature does not have a UI yet.

Let me discuss with my team. :)

@shinchris shinchris merged commit 4122e9c into tableau:development Mar 3, 2020
@shinchris
Copy link
Contributor

Thanks @guodah !

shinchris pushed a commit that referenced this pull request May 1, 2020
Merge development into master for v0.11 release

v0.11 (1 May 2020)

-Added more fields to Data Acceleration config (#588)
-Added OpenID as an auth setting enum (#610)
-Added support for Data Acceleration Reports (#596)
-Added support for view permissions (#526)
-Materialized views changed to Data Acceleration (#576)
-Improved consistency across workbook/datasource endpoints (#570)
-Fixed print error in update_connection.py (#602)
-Fixed log error in add user endpoint (#608)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants