Skip to content

Fix support for tags in ViewItem #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
irwando merged 2 commits into from
Jul 30, 2019
Merged

Fix support for tags in ViewItem #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf96f6d
Fix support for tags in ViewItem
Jul 24, 2019
c980315
Merge branch 'development' into 455-add-tags-to-view-item
toomyem Jul 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tableauserverclient/models/view_item.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import xml.etree.ElementTree as ET
from ..datetime_helpers import parse_datetime
from .exceptions import UnpopulatedPropertyError
from .tag_item import TagItem


class ViewItem(object):
Expand Down Expand Up @@ -119,6 +120,7 @@ def from_xml_element(cls, parsed_response, ns, workbook_id=''):
workbook_elem = view_xml.find('.//t:workbook', namespaces=ns)
owner_elem = view_xml.find('.//t:owner', namespaces=ns)
project_elem = view_xml.find('.//t:project', namespaces=ns)
tags_elem = view_xml.find('.//t:tags', namespaces=ns)
view_item._created_at = parse_datetime(view_xml.get('createdAt', None))
view_item._updated_at = parse_datetime(view_xml.get('updatedAt', None))
view_item._id = view_xml.get('id', None)
Expand All @@ -142,5 +144,10 @@ def from_xml_element(cls, parsed_response, ns, workbook_id=''):
elif workbook_elem is not None:
view_item._workbook_id = workbook_elem.get('id', None)

if tags_elem is not None:
tags = TagItem.from_xml_element(tags_elem, ns)
view_item.tags = tags
view_item._initial_tags = tags

all_view_items.append(view_item)
return all_view_items
4 changes: 4 additions & 0 deletions test/assets/view_get.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
<workbook id="3cc6cd06-89ce-4fdc-b935-5294135d6d42" />
<owner id="5de011f8-5aa9-4d5b-b991-f462c8dd6bb7" />
<project id="5241e88d-d384-4fd7-9c2f-648b5247efc5" />
<tags>
<tag label="tag1" />
<tag label="tag2" />
</tags>
</view>
<view id="fd252f73-593c-4c4e-8584-c032b8022adc" name="Overview" contentUrl="Superstore/sheets/Overview" createdAt="2002-05-30T09:00:00Z" updatedAt="2002-06-05T08:00:59Z" sheetType="story">
<workbook id="6d13b0ca-043d-4d42-8c9d-3f3313ea3a00" />
Expand Down
1 change: 1 addition & 0 deletions test/test_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ def test_get(self):
self.assertEqual('3cc6cd06-89ce-4fdc-b935-5294135d6d42', all_views[0].workbook_id)
self.assertEqual('5de011f8-5aa9-4d5b-b991-f462c8dd6bb7', all_views[0].owner_id)
self.assertEqual('5241e88d-d384-4fd7-9c2f-648b5247efc5', all_views[0].project_id)
self.assertEqual(set(['tag1', 'tag2']), all_views[0].tags)
self.assertIsNone(all_views[0].created_at)
self.assertIsNone(all_views[0].updated_at)
self.assertIsNone(all_views[0].sheet_type)
Expand Down