Skip to content

Change server_info endpoint error message to be verbose #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t8y8 merged 5 commits into from
May 29, 2019
Merged

Change server_info endpoint error message to be verbose #439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b64916d
Change server_info endpoint error message to be verbose
jacobj10 May 24, 2019
6d8ed2c
Update server_info_endpoint.py
jacobj10 May 24, 2019
9b5d520
Update server_info_endpoint.py
jacobj10 May 28, 2019
4c872db
Update server_info_endpoint.py
jacobj10 May 28, 2019
5d39e31
Encode square brackets in sort test response
jacobj10 May 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tableauserverclient/server/endpoint/server_info_endpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from .endpoint import Endpoint, api
from .exceptions import ServerResponseError, ServerInfoEndpointNotFoundError
from .exceptions import ServerResponseError, ServerInfoEndpointNotFoundError, EndpointUnavailableError
from ...models import ServerInfoItem
import logging

Expand All @@ -19,6 +19,8 @@ def get(self):
except ServerResponseError as e:
if e.code == "404003":
raise ServerInfoEndpointNotFoundError
if e.code == "404001":
raise EndpointUnavailableError

server_info = ServerInfoItem.from_response(server_response.content, self.parent_srv.namespace)
return server_info
2 changes: 1 addition & 1 deletion test/test_sort.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def test_filter_in(self):
auth_token='j80k54ll2lfMZ0tv97mlPvvSCRyD0DOM',
content_type='text/xml')

self.assertEqual(resp.request.query, 'pagenumber=13&pagesize=13&filter=tags:in:[stocks,market]')
self.assertEqual(resp.request.query, 'pagenumber=13&pagesize=13&filter=tags:in:%5bstocks,market%5d')

def test_sort_asc(self):
with requests_mock.mock() as m:
Expand Down