Skip to content

Conversation

@jorwoods
Copy link
Contributor

Closes #1322

Adds the ability to retrieve usage statistics when calling get_by_id for the Views endpoint.

@bcantoni
Copy link
Contributor

bcantoni commented Jun 4, 2024

@jorwoods I was going to test this, but I think it's missing adding total_views under models/view_item.py?

@jorwoods
Copy link
Contributor Author

jorwoods commented Jun 4, 2024

The total_views property already exists under the ViewItem. Getting usage information was already supported by server.views.get, this really just adds it to the get_by_id.

Copy link
Contributor

@bcantoni bcantoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I see it now! It was a problem on my side when testing. Changes look good!

@jorwoods jorwoods force-pushed the jorwoods/view_id_usage branch from 3055868 to c5d6abc Compare June 16, 2024 03:34
Copy link
Contributor

@jacalata jacalata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also submitted a docs bug to get this parameter added to our REST API docs!

@jacalata jacalata merged commit e6a709a into tableau:development Jun 20, 2024
@jorwoods jorwoods deleted the jorwoods/view_id_usage branch June 20, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants