feat: add JWTAuth #1219
Merged
feat: add JWTAuth #1219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacalata
requested changes
Apr 19, 2023
Contributor
jacalata
left a comment
jacalata
left a comment
There was a problem hiding this comment.
Could you just add a repr function for the JWTAuth class? something like
return "".format(self.jwt[:5]+ "...", self.site_id)
Contributor
Author
|
Done. How do you feel about explicitly marking the Additionally, I feel like |
Contributor
Author
|
Was there something missing from this PR that I should have implemented? |
Contributor
|
oops, I think this got auto-closed when I merged the dev branch |
jorwoods
force-pushed
the
jorwoods/JWTAuth
branch
from
c41fe47 to
31dd2c9
Compare
|
Will this branch be merged soon? Thanks in advance |
|
Hello, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
JWTAuthclass, as well as allowing Token auth to do impersonation.