Skip to content

Conversation

@narcolino-tableau
Copy link
Contributor

favorites_item.py and favorites_endpoint.py may be updated
these method examples were made prior to any updates

@salesforce-cla
Copy link

salesforce-cla bot commented Aug 4, 2022

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Nicole Arcolino <n***@i***.s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.

ma7tcsp and others added 6 commits April 12, 2023 12:26
TableauIDWithMFA added to the user_item model to allow creating users on Tableau Cloud with MFA enabled and to keep in sync with REST API.
Fixing Issue #1216
Removed redundant type listings in favorites
Cleaned up the from_response method for several items because we can now initialize them empty
@jacalata jacalata force-pushed the favs-sample-narcolino branch from 47cbe61 to 6a87c80 Compare April 18, 2023 22:45
@jacalata
Copy link
Contributor

I updated this to be ready for merging

  • created a union type of favoritable resources, and implemented the _set_permissions method on Metrics so that they all matched
  • made project id nullable

Nicole was an intern at the time she created this PR so the CLA is covered.

@jacalata jacalata merged commit cc62a50 into master Apr 19, 2023
@jacalata jacalata deleted the favs-sample-narcolino branch April 19, 2023 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants