-
Notifications
You must be signed in to change notification settings - Fork 447
Closed
Labels
infraInfrastructure issues (GitHub, etc)Infrastructure issues (GitHub, etc)
Description
In #835, Tyler formatted the whole tree with Black and removed pycodestyle from the GitHub workflow. At the time he mentioned that it was fully implemented yet in the workflow.
In parallel I had added steps for using a pre-commit hook that included pycodestyle. I'm assuming not many people are using that because the current source tree doesn't pass either style at this point. :)
Running black --check --line-length 120 tableauserverclient samples test on the development branch shows 71 files which would be reformatted.
I'm inclined to finish the work of implementing black:
- Swapping black for pycodestyle in the setup dependencies
- Edit the pre-commit hook example in docs
- Add a short explanation of black in the developer guide
- Add black to the workflow
- Do another big commit to make everything compliant with black again
Metadata
Metadata
Assignees
Labels
infraInfrastructure issues (GitHub, etc)Infrastructure issues (GitHub, etc)