Skip to content

Conversation

@jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Jan 21, 2021

Closes #472

@0golovatyi
Copy link
Contributor

@jayvdb Could you clarify why and when those additional files needed in the package?

@0golovatyi 0golovatyi closed this Jan 22, 2021
@jayvdb
Copy link
Contributor Author

jayvdb commented Jan 22, 2021

@0golovatyi , On #472 you said you were approving it, but here you closed it without merging.

@0golovatyi 0golovatyi reopened this Jan 22, 2021
@0golovatyi 0golovatyi merged commit edd5101 into tableau:master Jan 22, 2021
@0golovatyi
Copy link
Contributor

Sorry, my bad. Shouldn't have done it late night... Reopened and merged.

@jayvdb
Copy link
Contributor Author

jayvdb commented Jan 23, 2021

Minor note, not urgent, tag 2.3.2 hasnt been pushed to PyPI yet.

@jayvdb
Copy link
Contributor Author

jayvdb commented Jan 26, 2021

Still no 2.3.2 on PyPI @0golovatyi

@0golovatyi
Copy link
Contributor

@jayvdb There is no differences between 2.3.1 and 2.3.2 as test code is not added to the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PyPI sdist doesnt contain resources

2 participants