Skip to content

Conversation

@proddy
Copy link
Contributor

@proddy proddy commented Mar 7, 2025

Similar to #100

@proddy
Copy link
Contributor Author

proddy commented Mar 7, 2025

@rwieruch

@rwieruch
Copy link
Contributor

rwieruch commented Mar 7, 2025

Thanks mate!

@rwieruch rwieruch merged commit 535e741 into table-library:master Mar 7, 2025
@rwieruch
Copy link
Contributor

rwieruch commented Mar 7, 2025

Didn't test before, damn. There is a TypeScript error for the release.

@proddy
Copy link
Contributor Author

proddy commented Mar 7, 2025

sorry, that's my bad. I should have tested too. I just ran the jest tests and assumed it would build. I see AutoSizer returns React.ReactNode now and not a ReactElement. I can try and fix later tonight.

@Conorfu
Copy link

Conorfu commented Mar 17, 2025

Hi there! Just wanted to say we think your library is awesome and thank you for providing it 🙏 We were wondering if the version for this should actually be 1.0.25 as it looks like it was support for React 19 was included in that version bvaughn/react-virtualized-auto-sizer@0b8b181?

@proddy
Copy link
Contributor Author

proddy commented Mar 17, 2025

yes you're right! I overlooked that. It's tagged but doesn't show as a release (https://github.com/bvaughn/react-virtualized-auto-sizer/releases)

@Conorfu
Copy link

Conorfu commented Apr 8, 2025

Hi there! Was just wondering if there was any more progress on this? It looks like that 1.0.26 has been tagged now, (1.0.25 tagged as support for react 19) by the looks :) Again thank you so much guys for this awesome library!

@proddy
Copy link
Contributor Author

proddy commented Apr 8, 2025

I had a try at fixing it, but it requires a bit of work to replace the ReactElement with ReactNode. I think only @rwieruch can make this change.

@rwieruch
Copy link
Contributor

Version 4.1.13 is out. I think this should fix the issue that you tried to tackle here.

@proddy
Copy link
Contributor Author

proddy commented Apr 19, 2025

Almost! Can you also update "react-window": "1.8.7" to the latest 1.8.11 as that one supports React 19. See bvaughn/react-window@f61fd09

Now you get warnings like

➤ YN0060: │ react is listed by your project with version 19.1.0 (pd93e2), which doesn't satisfy what react-window (via @table-library/react-table-library) and other dependencies request (but they have non-overlapping ranges!).
➤ YN0060: │ react-dom is listed by your project with version 19.1.0 (pa3dc2), which doesn't satisfy what react-window (via @table-library/react-table-library) and other dependencies request (^18.0.0).
➤ YN0086: │ Some peer dependencies are incorrectly met by your project; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code.
➤ YN0086: │ Some peer dependencies are incorrectly met by dependencies; run yarn explain peer-requirements for details.
➤ YN0000: └ Completed

thanks!

@rwieruch
Copy link
Contributor

Can you try 4.1.15 ?

@proddy
Copy link
Contributor Author

proddy commented Apr 19, 2025

That's it! Warnings have gone. Thanks for the quick fix and happy easter :-)

@rwieruch
Copy link
Contributor

Same goes for you @proddy :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants