-
-
Notifications
You must be signed in to change notification settings - Fork 50
update react-virtualized-auto-sizer to 1.0.24 to support React19 #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks mate! |
|
Didn't test before, damn. There is a TypeScript error for the release. |
|
sorry, that's my bad. I should have tested too. I just ran the jest tests and assumed it would build. I see AutoSizer returns React.ReactNode now and not a ReactElement. I can try and fix later tonight. |
|
Hi there! Just wanted to say we think your library is awesome and thank you for providing it 🙏 We were wondering if the version for this should actually be 1.0.25 as it looks like it was support for React 19 was included in that version bvaughn/react-virtualized-auto-sizer@0b8b181? |
|
yes you're right! I overlooked that. It's tagged but doesn't show as a release (https://github.com/bvaughn/react-virtualized-auto-sizer/releases) |
|
Hi there! Was just wondering if there was any more progress on this? It looks like that 1.0.26 has been tagged now, (1.0.25 tagged as support for react 19) by the looks :) Again thank you so much guys for this awesome library! |
|
I had a try at fixing it, but it requires a bit of work to replace the ReactElement with ReactNode. I think only @rwieruch can make this change. |
|
Version 4.1.13 is out. I think this should fix the issue that you tried to tackle here. |
|
Almost! Can you also update Now you get warnings like thanks! |
|
Can you try 4.1.15 ? |
|
That's it! Warnings have gone. Thanks for the quick fix and happy easter :-) |
|
Same goes for you @proddy :) |
Similar to #100