-
Notifications
You must be signed in to change notification settings - Fork 3
Merge dev to main #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge dev to main #208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR merges development changes that split Kubernetes tooling into separate installation scopes and adds enhanced error handling and reporting. The changes introduce a new k8s_dev scope to separate development tools (helm, flux, cilium, etc.) from base Kubernetes tools, add tracking for successful/failed distro setups, and include a new pre-commit hook for detecting unwanted Unicode characters.
Key Changes:
- Split Kubernetes tools into three scopes:
k8s_base(core tools),k8s_dev(development/deployment tools), andk8s_ext(local cluster solutions) - Add success/failure tracking for WSL distro setup with improved end-of-script reporting
- Introduce a gremlins detection hook to prevent unwanted Unicode characters in text files
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| wsl/wsl_setup.ps1 | Refactored Kubernetes scope definitions, added distro success/failure tracking with SortedSet collections, enhanced error handling for root-only distros |
| wsl/wsl_install.ps1 | Updated parameter validation and documentation to include new k8s_dev scope |
| tests/hooks/gremlins.py | New Python script to detect and report forbidden Unicode characters in text files |
| .pre-commit-config.yaml | Added gremlins-check hook to pre-commit configuration |
| .assets/scripts/linux_setup.sh | Updated scope handling and installation order to support k8s_dev scope |
| .assets/provision/install_kustomize.sh | Added installation progress message |
| .assets/provision/install_kind.sh | New installation script for kind (Kubernetes in Docker) |
| .assets/provision/install_gh.sh | Refactored GitHub CLI installation to use package managers and improved key handling for Debian/Ubuntu |
| .assets/provision/install_flux.sh | Added installation progress message |
| .assets/provision/distro_check.sh | Added k8s_dev state check based on helm installation |
74427d2 to
8b3d8e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.
Improved keyring upudate reliability
Skip setup for the root WSL user.
Harden Debian based distros installation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated 7 comments.
No description provided.