fix area test for platforms in OMT process #854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cartes.app user noticed that
public_transport=platformwere never considered as areas.I checked
process_openmaptiles.luaand indeed noticed an inconsistency between:local is_highway_area = highway~="" and Find("area")=="yes" and is_closed, only forhighwayand
if highway ~= "" or public_transport == "platform" then, also forpublic_transportI modified the first in
local is_area = (public_transport == "platform" or Find("area")=="yes") and is_closedsincearea=yesis not required onpublic_transport=platformThis modification has been validated in https://codeberg.org/cartes/serveur/pulls/86