Sync dTBT changes from upstream #266
Conversation
crawfxrd
force-pushed
the
dtbt-sync
branch
2 times, most recently
from
04a63cd to
eb87d4a
Compare
There was a problem hiding this comment.
This seems to break Thunderbolt on the oryp12 (Maple Ridge). On currently released firmware, an HP dock works with both USB and Ethernet devices plugged into the dock. On this branch, the system still detects the dock as a Thunderbolt device, but the downstream USB and Ethernet devices don't show up.
|
Confirmed Thunderbolt works on master firmware (with coreboot 6982eaf), so the regression is specific to this PR. Here's dmesg after plugging in the dock with the working and non-working firmware: |
|
It's only allocating a single downstream bus for the TBT device itself, and failing to allocate any memory resources. Does the dock work if the it's connected before booting? |
Yes, just tried rebooting while it was plugged in, and it started working on the next boot. Seems to then work if I unplug and re-plug on the same boot, too. |
|
Can you get the output from |
|
Here you go: (I collected output both before and after plugging the dock in on the non-plugged boot, but they were identical.) |
Sync changes from CB:75286 and CB:76584. Change-Id: I0544ecb26869fa137f5bf59f0b510280611deaa1 Link: https://review.coreboot.org/c/coreboot/+/75286 Link: https://review.coreboot.org/c/coreboot/+/76584 Signed-off-by: Tim Crawford <[email protected]>
Change-Id: I2ce092ee8344034fd6e6a3493d3be17ac4c471f3 Signed-off-by: Tim Crawford <[email protected]>
|
Re-added the devicetree entries, which should hopefully fix hotplug. |
|
Just built & flashed with 876b0e1, and it's still not seeing the downstream devices on hotplug, only after rebooting. |
3 participants
Sync changes from CB:75286 and CB:76584.
Need to test on: