Skip to content

Fix incorrectly generated config file #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2023
Merged

Fix incorrectly generated config file #174

merged 1 commit into from
Jul 22, 2023

Conversation

2011eric
Copy link
Collaborator

According to the documentation,
the letter 'F' must occur before letter 'C' in ISA string.

@2011eric
Fix incorrectly generated config file
0e7db44 
According to the documentation,
the letter 'F' must occur before letter 'C' in ISA string.
@jserv jserv requested a review from Risheng1128 July 22, 2023 07:01
@2011eric
Copy link
Collaborator Author

The original setup.py lead to this message when using make arch-test RISCV_DEVICE=IMFCZicsrZifencei:

ERROR | Error in /home/eric2011/src/working/rv32emu/tests/arch-test-target/rv32emu/rv32emu_isa.yaml.
ERROR |  ISA:
ERROR |   - Alphabet 'C' should occur after 'F

Here is the documentaion about config file: https://riscv-config.readthedocs.io/en/stable/yaml-specs.html#isa

@jserv jserv merged commit 7cdb2fc into sysprog21:master Jul 22, 2023
vestata pushed a commit to vestata/rv32emu that referenced this pull request Jan 24, 2025
@jserv
Merge pull request sysprog21#174 from 2011eric/master
1d5f3dd 
Fix incorrectly generated config file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Risheng1128 Risheng1128 Risheng1128 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@2011eric @Risheng1128 @jserv