Consolidate CI/CD test for gdbstub #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
changed the title
Risheng1128
approved these changes
May 16, 2023
|
Thank @RinHizakura for contributing! |
vestata
pushed a commit
to vestata/rv32emu
that referenced
this pull request
Jan 24, 2025
Consolidate CI/CD test for gdbstub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't get expected result when running
make gdbstub-testunder the old version ofrv32emu. That's because the implementation ofrv_stepchanged from returning after stepping single instruction to returning after a block execution. To solve the issue, I simply take gdbstub mode as a special case forrv_step, which will return directly after executing one instruction, so we can check whether the breakpoint hit after every return.After the changed, we can add the test of gdbstub mode in CICD now. The workflow of CICD is also changed a little bit since we'll need
riscv32-gdbfor the test on gdbstub.