Fix the implementations of FCVT.S.W and FCVT.S.WU #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementations of FCVT.S.W and FCVT.S.WU in the commit 04ce561 are incorrect. In fact, instead of updating the bit representation of the float number directly, a correct implementation should convert the signed/unsigned number to float number while keeping the value of integer numbers. As a result, I use implicit conversion between integer and float at line 1031 and 1034 and assigned the converted value to rv->F rather than rv->F_int, which represent the float number itself and its representation, respectively.
|
After examination, this patch fixes the segmentation fault error that occurs during the |
qwe661234
approved these changes
Apr 29, 2023
|
Thank @alanjian85 for contributing! |
vestata
pushed a commit
to vestata/rv32emu
that referenced
this pull request
Jan 24, 2025
Fix the implementations of FCVT.S.W and FCVT.S.WU
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementations of FCVT.S.W and FCVT.S.WU in the commit 04ce561 are incorrect. In fact, instead of updating the bit representation of the float number directly, a correct implementation should convert the signed/unsigned number to float number while keeping the value of integer numbers. As a result, I use implicit conversion between integer and float at line 1031 and 1034 and assigned the converted value to rv->F rather than rv->F_int, which represent the float number itself and its representation, respectively.