Patch for issue #98 #100
Merged
Patch for issue #98 #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
requested changes
Dec 22, 2022
jserv
reviewed
Dec 22, 2022
After finishing emulating, all instructions must increase csr cycle, but we only do so for branch instructions.
In the previous implementation, fencei was treated as a branch instruction, but it was assigned a missing value in the new branch list. As a result, emulator fails to pass Zifencei test. Close: sysprog21#98
vestata
pushed a commit
to vestata/rv32emu
that referenced
this pull request
Jan 24, 2025
Resolve Zifencei incompatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the patch commits for commit a304446.