Utilize GitHub Actions for building and running via QEMU #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
requested changes
Jul 4, 2025
Contributor
jserv
left a comment
jserv
left a comment
There was a problem hiding this comment.
Rebase the latest main branch.
jserv
reviewed
Jul 4, 2025
Contributor
|
There should be only a commit, discarding unrelated ones. |
Contributor
Author
Already.
Sure. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
G36maid
force-pushed
the
ci
branch
2 times, most recently
from
761c4b2 to
bdf027c
Compare
Damien-Chen
reviewed
Jul 5, 2025
G36maid
force-pushed
the
ci
branch
2 times, most recently
from
3839694 to
cc104df
Compare
jserv
requested changes
Jul 6, 2025
Contributor
jserv
left a comment
jserv
left a comment
There was a problem hiding this comment.
Carefully read https://cbea.ms/git-commit/ and strictly apply its rules when writing full sentences in commit messages.
jserv
reviewed
Jul 6, 2025
Contributor
Author
I'll make sure to rebase properly before merging. For now, I prefer to keep the commits. |
G36maid
force-pushed
the
ci
branch
3 times, most recently
from
e792176 to
7c49a01
Compare
Contributor
Author
|
Do these results match what we wanted? |
jserv
reviewed
Jul 30, 2025
visitorckw
reviewed
Oct 23, 2025
G36maid
force-pushed
the
ci
branch
2 times, most recently
from
182b393 to
68cab6a
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 issues found across 6 files
Prompt for AI agents (all 3 issues)
Understand the root cause of the following 3 issues and fix them.
<file name=".ci/run-app-tests.sh">
<violation number="1" location=".ci/run-app-tests.sh:32">
A timeout (exit code 124 from `timeout`) indicates the QEMU run hung, but this branch treats it as a pass. That masks failures and lets broken apps appear healthy; only exit code 0 should be considered passing.</violation>
</file>
<file name="arch/riscv/build.mk">
<violation number="1" location="arch/riscv/build.mk:22">
The clang detection runs $(CROSS_COMPILE)gcc --version, but the LLVM toolchain only ships $(CROSS_COMPILE)clang, so CC_IS_CLANG never becomes 1 and the build selects the missing GNU binaries, breaking LLVM builds.</violation>
</file>
<file name=".ci/ci-tools.sh">
<violation number="1" location=".ci/ci-tools.sh:187">
The aggregated gnu apps section writes values like `app1=passed` without quotes, producing invalid TOML that downstream tools cannot parse.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
G36maid
force-pushed
the
ci
branch
5 times, most recently
from
cf192bf to
c89b134
Compare
visitorckw
reviewed
Oct 24, 2025
jserv
requested changes
Oct 28, 2025
Contributor
jserv
left a comment
jserv
left a comment
There was a problem hiding this comment.
Rebase the latest main branch.
G36maid
force-pushed
the
ci
branch
3 times, most recently
from
e7b8142 to
a937b7f
Compare
Implement GitHub Actions CI pipeline for testing Linmo across GNU and LLVM RISC-V toolchains with automated reporting. Features: - Matrix testing for GNU and LLVM toolchains - Automated app discovery and crash detection - Functional test framework with criterion-based validation - TOML-based result aggregation across toolchains - Automated PR comments with detailed test results - Proper failure handling and artifact collection Components: - .ci/ci-tools.sh: Unified tool for data collection, aggregation, and PR comment formatting - .ci/run-app-tests.sh: Automated app testing with QEMU - .ci/run-functional-tests.sh: Criterion-based functional tests - .ci/setup-toolchain.sh: Automated toolchain installation - .github/workflows/ci.yml: Complete CI workflow with summary job The workflow ensures all tests run to completion, captures full output for debugging, and fails CI based on the aggregated overall status.
Contributor
|
Thank @G36maid for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement GitHub Actions CI pipeline for testing Linmo across GNU and
LLVM RISC-V toolchains with automated reporting.
Features:
Components:
and PR comment formatting
The workflow ensures all tests run to completion, captures full output
for debugging, and fails CI based on the aggregated overall status
Fixes #2
Depend on #31