Stats freq overflow #3320
Merged
Stats freq overflow #3320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kokan <[email protected]>
The gint freq could hold the value 2^31-1, that later used in the code as: ``` timespec_add_msec(&timer->expires, freq * 1000); ``` While the timespec_add_msec last argument is a glong that could hold 1000*2^31-1, the multiplication happens in the gint domain, which overflows yielding a negative number. Causing the timer imidiate trigger. Signed-off-by: Kokan <[email protected]>
Signed-off-by: Kokan <[email protected]>
|
Build SUCCESS |
MrAnno
approved these changes
Jun 12, 2020
lbudai
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
stats-freqoption could go as high as2^31-1(which of course kinda unrealistic), but the opposite happens, the stats reports start to spawn right away in an infinite loop manner.When timer is adjusted (
timespec_add_msec(&timer->expires, freq * 1000);) thefreq * 1000is used, where thefreqhas the typegint, and the function - correctly - waits aglong, but the multiplication happens before the parameter assignment and in the domain ofgintthat yieldsgintoverflow.