Skip to content

Conversation

patrickdepinguin
Copy link
Contributor

The option '--with-net-snmp' did not work, because later checks were using
the variable '$with_netsnmp' rather than '$with_net_snmp'.
As a result, the net-snmp-config option was always searched in the PATH.

There are two possible solutions:

  • make the option '--with-netsnmp'
  • change the internal variables

Opt for the second option so the user-visible options remain the same.

Signed-off-by: Thomas De Schampheleire [email protected]

(Note: I did not add a news item as I think very few people actually use this, and it was broken for almost a year, let me know if you would prefer one)

The option '--with-net-snmp' did not work, because later checks were using
the variable '$with_netsnmp' rather than '$with_net_snmp'.

There are two possible solutions:
- make the option '--with-netsnmp'
- change the internal variables

Opt for the second option so the user-visible options remain the same.

Signed-off-by: Thomas De Schampheleire <[email protected]>
@kira-syslogng
Copy link
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
"add to whitelist" add author of a Pull Request to whitelist (globally, be careful, it means this user can trigger kira for any PR)
do nothing -> CI won't start)

2 similar comments
@kira-syslogng
Copy link
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
"add to whitelist" add author of a Pull Request to whitelist (globally, be careful, it means this user can trigger kira for any PR)
do nothing -> CI won't start)

@kira-syslogng
Copy link
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
"add to whitelist" add author of a Pull Request to whitelist (globally, be careful, it means this user can trigger kira for any PR)
do nothing -> CI won't start)

@Kokan
Copy link
Collaborator

Kokan commented Mar 18, 2020

@kira-syslogng ok to test

@kira-syslogng
Copy link
Contributor

Build SUCCESS

@furiel
Copy link
Collaborator

furiel commented Mar 19, 2020

Thank you for the fix!

I would prefer to see a changenote . Users might have not used it either because they were unaware of this option, in which case advertizing would help. Or they workarounded it, in which case they may be interested in the change.

Either way, I think it worths a simple entry in the packaging category.

Copy link
Collaborator

@gaborznagy gaborznagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patch!

@gaborznagy gaborznagy merged commit 1f22871 into syslog-ng:master Mar 20, 2020
@patrickdepinguin
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants