Skip to content

libtest: install missing libtest headers #3179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2020
Merged

libtest: install missing libtest headers #3179

merged 1 commit into from
Mar 18, 2020

Conversation

alltilla
Copy link
Collaborator

@alltilla alltilla commented Mar 18, 2020 •
edited
Loading

Signed-off-by: Attila Szakacs [email protected]

@alltilla alltilla changed the title libtest: install config_parse_lib.h libtest: install config_parse_lib.h Mar 18, 2020
@kira-syslogng
Copy link
Contributor

Build SUCCESS

@alltilla alltilla force-pushed the config_parse_lib_install branch from 846aa09 to 3f00cd5 Compare March 18, 2020 09:26
@kira-syslogng
Copy link
Contributor

Build SUCCESS

furiel
furiel previously approved these changes Mar 18, 2020
View reviewed changes
MrAnno
MrAnno previously approved these changes Mar 18, 2020
View reviewed changes
Copy link
Collaborator

@MrAnno MrAnno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
I've found 3 more missing headers:

queue_utils_lib.h
mock-cfg-parser.h
fake-time.h

@alltilla alltilla dismissed stale reviews from MrAnno and furiel via ca10d25 March 18, 2020 10:29
@alltilla alltilla force-pushed the config_parse_lib_install branch from 3f00cd5 to ca10d25 Compare March 18, 2020 10:29
@alltilla alltilla changed the title libtest: install config_parse_lib.h libtest: install missing libtest headers Mar 18, 2020
MrAnno
MrAnno approved these changes Mar 18, 2020
View reviewed changes
Copy link
Collaborator

@MrAnno MrAnno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kira-syslogng
Copy link
Contributor

Build SUCCESS

@lbudai lbudai merged commit 531d70b into syslog-ng:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@MrAnno MrAnno MrAnno approved these changes

@lbudai lbudai lbudai approved these changes

@furiel furiel furiel left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alltilla @kira-syslogng @MrAnno @lbudai @furiel