cmake, autotools: -Wundef to enable-extra-warning #2806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build FAILURE |
|
@kira-syslogng retest this please |
|
Build FAILURE |
furiel
force-pushed
the
undefined-warnings
branch
from
18771db to
2a32fba
Compare
|
Build FAILURE |
furiel
force-pushed
the
undefined-warnings
branch
from
2a32fba to
3b6ecd9
Compare
|
Build FAILURE |
furiel
force-pushed
the
undefined-warnings
branch
from
3b6ecd9 to
18c6a3e
Compare
|
Build SUCCESS |
furiel
force-pushed
the
undefined-warnings
branch
2 times, most recently
from
072f8f7 to
1f6160e
Compare
|
Thanks @bazsi for the info! I eliminated the dlsym related code. |
furiel
force-pushed
the
undefined-warnings
branch
from
1f6160e to
58b7ec7
Compare
|
Build SUCCESS |
alltilla
reviewed
Jul 1, 2019
furiel
force-pushed
the
undefined-warnings
branch
from
58b7ec7 to
ca24c13
Compare
|
Build SUCCESS |
Signed-off-by: Antal Nemes <[email protected]>
Signed-off-by: Mehul Prajapati <[email protected]>
Signed-off-by: Mehul Prajapati <[email protected]>
Signed-off-by: Antal Nemes <[email protected]>
The idea has been that eventlog would become a useful library on its own that can be LD_PRELOADed into any executable and make logging more verbose. After merging evtlog into syslog-ng, it functionality is not relevant anymore. Signed-off-by: Antal Nemes <[email protected]>
Signed-off-by: Mehul Prajapati <[email protected]>
Signed-off-by: Antal Nemes <[email protected]>
Signed-off-by: Antal Nemes <[email protected]>
Signed-off-by: Antal Nemes <[email protected]>
AC_CHECK_FUNCS only define SYSLOG_NG_HAVE_... if condition the symbol is found. cmakedefine01 defines something in any case, hence a conflict. The correct way of handling the problem is not to use cmakedefine01 but cmakedefine, and use if(n)def inside the code. AC_DEFINE_UNQUOTED(HAVE_GETRANDOM) can/need be removed because it is also detected by AC_CHECK_FUNCS too. Signed-off-by: Antal Nemes <[email protected]>
Signed-off-by: Mehul Prajapati <[email protected]>
Signed-off-by: Mehul Prajapati <[email protected]>
furiel
force-pushed
the
undefined-warnings
branch
from
ca24c13 to
504b185
Compare
|
Build SUCCESS |
bazsi
approved these changes
Jul 10, 2019
alltilla
approved these changes
Jul 10, 2019
furiel
added a commit
to furiel/syslog-ng
that referenced
this pull request
Jul 12, 2019
Regression from syslog-ng#2806. cmakedefine01 and add_definitions both define the same identifier. Signed-off-by: Antal Nemes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #2678, adding a few changes.
Please check the individual commits. One inconvenience comes from the difference from cmake and autotools:
AC_CHECK_FUNCSonly define a compiler switch if the symbol is found. However#cmakedefine01defines it unconditionally to 0 or 1. The resolution is to use#cmakedefineinstead of#cmakedefine01. Inside the code, we need to use#if(n)definstead if#ifin those cases.