amqp: heartbeat support

[nobles]

Users can provide heartbeat in their configuration, that is negotiated with the server. In case heartbeat is enabled, amqp destination will send heartbeats periodically.

Heartbeat is measured in seconds. Default value is zero.

Example configuration:

    destination { amqp(vhost("/")
                  exchange("logs")
                  body("hello world")
                  heartbeat(10)
                  username(guest) password(guest)); };

Fixes: #189

[kira-syslogng]

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
do nothing -> CI won't start)

[kira-syslogng]

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
do nothing -> CI won't start)

[furiel]

@kira-syslogng ok to test

[kira-syslogng]

Build SUCCESS

[kira-syslogng]

Build FAILURE

[furiel]

@kira-syslogng retest this please

[kira-syslogng]

Build SUCCESS

[kira-syslogng]

Build FAILURE

[nobles]

@kira-syslogng retest this please

[furiel]

@kira-syslogng retest this please

[kira-syslogng]

Build SUCCESS

[Kokan]

thanks for fixing one of the oldest issue/feature request 🥇

[gaborznagy]

This is for the documentation:
As I read the docs, heartbeat can only be turned off, if BOTH sides has a heartbeat value of 0.
https://www.rabbitmq.com/heartbeats.html

Heartbeats can be disabled by setting the timeout interval to 0 on both client and server ends.

On code side we have this debug message, so there is nothing more to do, it's just worth to mention in the docs.

[gaborznagy]

UPDATE: I've tried this out and this statement seems invalid.
What I've concluded is that generally the negotiated heartbeat interval will be the smaller configured one.
About disabling heartbeating: Client controls enable/disable, therefore even if the server side has an explicit 0 for heartbeat, a client can override this. If the client has a 0, it means disable heartbeat.
(tested with RabbitMQ 3.6.10 server and client 0.8.0 versions).

[nobles]

I needed to force push because of conflict

[kira-syslogng]

Build SUCCESS

[gaborznagy]

Approve from my side.

I would like to update the PR description emphasizing that the heartbeat interval is configured, not the timeout.