groupingby: identical persist name #2659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build SUCCESS |
furiel
reviewed
Apr 5, 2019
Signed-off-by: Kokan <[email protected]>
Signed-off-by: Kokan <[email protected]>
Signed-off-by: Kokan <[email protected]>
Signed-off-by: Kokan <[email protected]>
Kokan
force-pushed
the
groupingby_persist_name
branch
from
cef4fd1 to
eeaad8f
Compare
furiel
previously approved these changes
Apr 8, 2019
|
Build FAILURE |
Signed-off-by: Kokan <[email protected]>
Kokan
force-pushed
the
groupingby_persist_name
branch
from
eeaad8f to
a35fd81
Compare
|
Build SUCCESS |
furiel
approved these changes
Apr 9, 2019
lbudai
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
grouping-bystores some information between reloads in cfg persist, but it uses a fixedgrouping-by()persist name to store its keys. Using two group-by in configuration causes issues:Note: this PR does not actully solves the above issue, but aims to help a little bit via including the
keyinto the name.