afamqp: add support for external authentication #2626
Merged
+53
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This user does not have permission to start the build. Can one of the admins verify this patch and start the build? |
|
@kira-syslogng ok to test |
bazsi
reviewed
Mar 13, 2019
|
Build SUCCESS |
Kokan
reviewed
Mar 13, 2019
AMQP has support for an 'external' authentication scheme which uses some out-of-band method for authenticating the user. For instance, the user may be identified from the Distinguished Name or Common Name in their client certificate. The method by which the user is identified when using external authentication depends on the server configuration. Add a new 'auth-method' parameter to the amqp destination configuration which may be set to 'plain' or 'external'. When this parameter is omitted or set to 'plain', the existing behaviour is unchanged. When set to 'external' then external authentication is enabled and the username, if supplied, will be used as the identity, although this is generally not needed and may be omitted. Signed-off-by: Chris Spencer <[email protected]>
|
Build SUCCESS |
|
External authentication is mentioned in the RabbitMQ documentation. I'm having trouble finding anything AMQP-specific so it's possible it's just a RabbitMQ thing. I have addressed your comments. Thanks. |
gaborznagy
approved these changes
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AMQP has support for an 'external' authentication scheme which uses some out-of-band method for authenticating the user. For instance, the user may be identified from the Distinguished Name or Common Name in their client certificate. The method by which the user is identified when using external authentication depends on the server configuration.
Add a new 'auth-method' parameter to the amqp destination configuration which may be set to 'plain' or 'external'. When this parameter is omitted or set to 'plain', the existing behaviour is unchanged. When set to 'external' then external authentication is enabled and the username, if supplied, will be used as the identity, although this is generally not needed and may be omitted.