Skip to content

test_template_on_error: rewrite test cases in criterion #2584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2019
Merged

test_template_on_error: rewrite test cases in criterion #2584

merged 1 commit into from
Mar 4, 2019

Conversation

mehul-m-prajapati
Copy link
Contributor

fixes #2578

@kira-syslogng
Copy link
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
do nothing -> CI won't start)

1 similar comment
@kira-syslogng
Copy link
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
do nothing -> CI won't start)

@Kokan
Copy link
Collaborator

Kokan commented Feb 28, 2019

@kira-syslogng ok to test

@kira-syslogng
Copy link
Contributor

Build SUCCESS

Kokan
Kokan previously approved these changes Mar 1, 2019
View reviewed changes
furiel
furiel suggested changes Mar 1, 2019
View reviewed changes
Copy link
Collaborator

@furiel furiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changeset! I have only one request for eliminating the domain specific assert macros with criterion features.

@mehul-m-prajapati mehul-m-prajapati force-pushed the test-template-on-error-criterion branch from 7209aa2 to 6cea30b Compare March 2, 2019 22:37
@kira-syslogng
Copy link
Contributor

Build SUCCESS

@mehul-m-prajapati mehul-m-prajapati force-pushed the test-template-on-error-criterion branch from 6cea30b to 13ecea2 Compare March 2, 2019 23:06
@kira-syslogng
Copy link
Contributor

Build SUCCESS

@mehul-m-prajapati mehul-m-prajapati force-pushed the test-template-on-error-criterion branch from 13ecea2 to 49b297c Compare March 3, 2019 16:05
@kira-syslogng
Copy link
Contributor

Build SUCCESS

@Kokan Kokan merged commit 892d9a6 into syslog-ng:master Mar 4, 2019
@mehul-m-prajapati mehul-m-prajapati deleted the test-template-on-error-criterion branch March 5, 2019 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Kokan Kokan Kokan approved these changes

@furiel furiel furiel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

convert ut test_template_on_error to criterion

4 participants

@mehul-m-prajapati @kira-syslogng @Kokan @furiel