collect-cov.sh: make coverage should work with lcov in bionic #2515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our devshell image is bionic based so make sure our coverage targets work with the version of lcov that is on bionic. lcov seems to be changing configuration options quite frequently, but I think it is enough to work in devshell. Signed-off-by: Balazs Scheidler <[email protected]>
|
Build SUCCESS |
Kokan
reviewed
Jan 30, 2019
| lcov --capture --directory `pwd` --compat-libtool --output-file coverage.info --rc geninfo_auto_base=1 | ||
| lcov --capture --directory `pwd` --compat-libtool --output-file coverage.info | ||
| lcov --extract coverage.info "${top_srcdir}/*" --output-file coverage.info | ||
| lcov --remove coverage.info "${top_srcdir}/modules/afmongodb/mongo-c-driver/*" --output-file coverage.info |
There was a problem hiding this comment.
Not related to this PR, but the mongo-c-driver and rabbitmq-c submodules are no longer part of the projects so there is no need to exclude them.
There was a problem hiding this comment.
@Kokan: indeed, we should remove them.
Kokan
approved these changes
Jan 30, 2019
lbudai
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our devshell image is bionic based so make sure our coverage targets
work with the version of lcov that is on bionic.
lcov seems to be changing configuration options quite frequently, but
I think it is enough to work in devshell.
Signed-off-by: Balazs Scheidler [email protected]