Afsql flush lines cleanup #2392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

furiel merged 1 commit into syslog-ng:master from lbudai:afsql-flush-lines-cleanup

Nov 13, 2018

Collaborator

lbudai commented Nov 5, 2018

depends on #2386

Contributor

kira-syslogng commented Nov 5, 2018

Build FAILURE

bazsi reviewed

View reviewed changes

lib/cfg-parser.c Outdated Show resolved Hide resolved

bazsi reviewed

View reviewed changes

modules/afsql/afsql-parser.c Outdated Show resolved Hide resolved

bazsi reviewed

View reviewed changes

modules/afsql/afsql.c Outdated Show resolved Hide resolved

bazsi reviewed

View reviewed changes

modules/http/http-parser.c Outdated Show resolved Hide resolved

bazsi reviewed

View reviewed changes

modules/riemann/riemann-parser.c Outdated Show resolved Hide resolved

bazsi reviewed

View reviewed changes

Collaborator

bazsi left a comment

Looks good to me in general, with minor changes requested.

lbudai force-pushed the afsql-flush-lines-cleanup branch from b6a2858 to 97b9d6c Compare

November 6, 2018 12:18

Contributor

kira-syslogng commented Nov 6, 2018

Build SUCCESS

lbudai added the user-visible-feature label

lbudai added this to the OSE 3.19 milestone

lbudai force-pushed the afsql-flush-lines-cleanup branch from 97b9d6c to 42e05e6 Compare

November 7, 2018 11:37

Contributor

kira-syslogng commented Nov 7, 2018

Build FAILURE

lbudai force-pushed the afsql-flush-lines-cleanup branch from 42e05e6 to 0324ef0 Compare

November 7, 2018 12:56

Contributor

kira-syslogng commented Nov 7, 2018

Build SUCCESS

gaborznagy self-requested a review

November 10, 2018 10:03

Collaborator

gaborznagy commented Nov 10, 2018

@lbudai can you do a rebase, please as #2386 merged?
I think the PR will be just 1 commit.

lbudai force-pushed the afsql-flush-lines-cleanup branch from 0324ef0 to 223f383 Compare

November 12, 2018 07:37

Collaborator Author

lbudai commented Nov 12, 2018

@gaborznagy : rebased

Contributor

kira-syslogng commented Nov 12, 2018

Build SUCCESS

furiel previously approved these changes

View reviewed changes

gaborznagy reviewed

View reviewed changes

modules/afsql/afsql.h Outdated Show resolved Hide resolved

modules/afsql/afsql.c Outdated Show resolved Hide resolved

gaborznagy suggested changes

View reviewed changes

Collaborator

gaborznagy left a comment

Please fix num_retries and setter function leftover.


          afsql: use threaded_dest_driver_option instead of dest_driver_option

5ea103f

note: when flush-lines was inherited from global config, the default
value was 100: it is important to keep this default value, otherwise,
the transaction remain uncommitted until syslog-ng eats all the memory

Signed-off-by: Laszlo Budai <[email protected]>

lbudai dismissed furiel’s stale review via

5ea103f

November 13, 2018 12:13

lbudai force-pushed the afsql-flush-lines-cleanup branch from 223f383 to 5ea103f Compare

November 13, 2018 12:13

Collaborator Author

lbudai commented Nov 13, 2018

updated

gaborznagy approved these changes

View reviewed changes

Contributor

kira-syslogng commented Nov 13, 2018

Build SUCCESS

furiel approved these changes

View reviewed changes

furiel merged commit 12d90e9 into syslog-ng:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet