lib/gsockaddr.c: modify the unix salen calculation #2285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build SUCCESS |
It is not required on all platforms to add the size of the terminating null character (+1) to the value of the addrlen parameter during the bind system call. Most platforms has a built in MACRO to calculate the proper value, called SUN_LEN. SUN_LEN is not a POSIX standard, so we use the formula from the Linux man page if it is not available. Signed-off-by: Laszlo Szemere <[email protected]>
szemere
force-pushed
the
fix_unix_domain_addrlen
branch
from
6444ac3 to
623c39a
Compare
szemere
changed the title
|
Build SUCCESS |
lbudai
reviewed
Sep 17, 2018
lib/gsockaddr.c
Outdated
| return sizeof(addr->saun) - sizeof(addr->saun.sun_path) + strlen(addr->saun.sun_path) + 1; | ||
| #endif | ||
| } | ||
|
|
There was a problem hiding this comment.
So we have a platform where SUN_LEN is not defined? :)
I'd define SUN_LEN in a compat header.
What do you think?
an alternative impl.:
http://lists.llvm.org/pipermail/lldb-commits/Week-of-Mon-20151026/024736.html
Does this have the same result?
Signed-off-by: Laszlo Szemere <[email protected]>
|
@szemere : Thanks! |
lbudai
approved these changes
Sep 18, 2018
|
Build SUCCESS |
gaborznagy
approved these changes
Sep 18, 2018
gaborznagy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not required on all platforms to add the size of the
terminating null character (+1) to the value of the
addrlenparameter during the
bindsystem call. Most platforms has abuilt in MACRO to calculate the proper value, called
SUN_LEN.SUN_LEN is not a POSIX standard, so we use the formula from
the Linux man page if it is not available.
Signed-off-by: Laszlo Szemere [email protected]