-
Notifications
You must be signed in to change notification settings - Fork 494
Undefined filter reference #2273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build FAILURE |
@kira-syslogng retest this please; |
Build SUCCESS |
bazsi
previously approved these changes
Sep 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, nice catch.
58fca6b
to
60913bf
Compare
The only change that in case of |
60913bf
to
6002e6a
Compare
Build SUCCESS |
MrAnno
previously approved these changes
Sep 13, 2018
6002e6a
to
13a83f8
Compare
Signed-off-by: Kokan <[email protected]>
Signed-off-by: Kokan <[email protected]>
13a83f8
to
390bf6f
Compare
Build SUCCESS |
MrAnno
approved these changes
Sep 13, 2018
furiel
approved these changes
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
filter
filter could refer to other filter, which is checked during the initialization time instead of configuration parse time. But at this point for some reason syslog-ng only reported as an error message:Referenced filter rule not found in filter() expression ...
The syslog-ng should not start in this case, and this patch solves that.