Skip to content

Conversation

Kokan
Copy link
Collaborator

@Kokan Kokan commented Sep 12, 2018

The filter filter could refer to other filter, which is checked during the initialization time instead of configuration parse time. But at this point for some reason syslog-ng only reported as an error message:
Referenced filter rule not found in filter() expression ...

The syslog-ng should not start in this case, and this patch solves that.

@Kokan Kokan changed the title Filter undefined filter reference Undefined filter reference Sep 12, 2018
@kira-syslogng
Copy link
Contributor

Build FAILURE

@Kokan
Copy link
Collaborator Author

Kokan commented Sep 12, 2018

@kira-syslogng retest this please;

@kira-syslogng
Copy link
Contributor

Build SUCCESS

bazsi
bazsi previously approved these changes Sep 13, 2018
Copy link
Collaborator

@bazsi bazsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice catch.

@Kokan Kokan changed the title Undefined filter reference [WIP] Undefined filter reference Sep 13, 2018
@Kokan Kokan force-pushed the filter-undefined-ref branch from 58fca6b to 60913bf Compare September 13, 2018 11:22
@Kokan Kokan changed the title [WIP] Undefined filter reference Undefined filter reference Sep 13, 2018
@Kokan
Copy link
Collaborator Author

Kokan commented Sep 13, 2018

The only change that in case of fop_init it returned with TRUE, but it should check against its parameters init.

@Kokan Kokan force-pushed the filter-undefined-ref branch from 60913bf to 6002e6a Compare September 13, 2018 11:44
@kira-syslogng
Copy link
Contributor

Build SUCCESS

MrAnno
MrAnno previously approved these changes Sep 13, 2018
@Kokan Kokan force-pushed the filter-undefined-ref branch from 13a83f8 to 390bf6f Compare September 13, 2018 17:46
@kira-syslogng
Copy link
Contributor

Build SUCCESS

@furiel furiel merged commit 7521f4b into syslog-ng:master Sep 13, 2018
@Kokan Kokan deleted the filter-undefined-ref branch September 13, 2018 19:30
@lbudai lbudai added this to the OSE 3.18 milestone Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants