Fix a groupset/groupunset and map-value-pairs() crash #2184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The template_options parameter of value_pairs_foreach() is mandatory, because it is used by log_macro_expand() (through vp_merge_builtins()). Signed-off-by: László Várady <[email protected]>
|
Build SUCCESS |
lbudai
approved these changes
Jul 13, 2018
furiel
approved these changes
Jul 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
template_optionsparameter ofvalue_pairs_foreach()is mandatory, because it is used bylog_macro_expand()(throughvp_merge_builtins()).There are additional (serious) problems with groupset/groupunset and value-pairs (see: #1673 (comment) and #1673 (comment)), but fixing the crash itself might not be a bad idea.
Fixes #1673