valgrind support for unit tests #1839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
Kokan
approved these changes
Jan 31, 2018
lib/stats/tests/test_stats_query.c
Outdated
Signed-off-by: bkil-syslogng <[email protected]>
furiel
force-pushed
the
unit-test-valgrind
branch
from
7c71d1e to
7a2f130
Compare
Kokan
approved these changes
Jan 31, 2018
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
Signed-off-by: bkil-syslogng <[email protected]>
Signed-off-by: Antal Nemes <[email protected]>
One cannot deserialize into a cleared message: the deserialization code always allocates new array for sdata, while clear only sets the number of stored sdata to 0, leaving the pointer alone. An assert is added to the deserialization code to make this hidden dependency sure. Signed-off-by: Antal Nemes <[email protected]>
Appending null to g_string in single cluster case. "" should be used in the cluster name instead of NULL. Signed-off-by: Antal Nemes <[email protected]>
Signed-off-by: bkil-syslogng <[email protected]>
Usage: make check-valgrind-tool (optional VALGRIND_TOOL=memcheck) Signed-off-by: bkil-syslogng <[email protected]>
Execution: ctest -T memcheck Signed-off-by: Antal Nemes <[email protected]>
furiel
force-pushed
the
unit-test-valgrind
branch
from
7a2f130 to
b549709
Compare
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is the continuation of #1080. Thank you @bkil-syslogng for the investigation and putting together the original pull request.
I moved most of the commits from the original pull request here. One notable exception is the travis part. Unfortunately the valgrind execution of the unit test set is too long to execute in travis.
Besides autotools, cmake support is added as well.
Usage:
autotools
cmake
After the usual compile: one can execute