Kv scanner scratch buffers #1789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uld be using a local variable This patch gets rid off the reuse of KVScanner instances accross different messages in production. KVScanners have never been threadsafe, and thus a cloning of it was introduced for every message received. This patch gets rid off the clone and rather takes the performance hit of having to allocate a couple of GString instances, and making the KVScanner instance a local variable in the process function. Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
…t loop As the production code does that same, so these numbers are more realistic. Signed-off-by: Balazs Scheidler <[email protected]>
|
Removes a lot of boilerplate, increases performance, and resolves a race. :) |
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
Signed-off-by: Balazs Scheidler <[email protected]> Signed-off-by: László Várady <[email protected]>
MrAnno
force-pushed
the
kv-scanner-scratch-buffers
branch
from
ec85630 to
43007c5
Compare
MrAnno
approved these changes
Dec 3, 2017
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
|
Tested with the reproduction in #1773, syslog-ng did not crash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative for #1787