Skip to content

doc: clarify optional cloudtrail_sns region requirement #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2022
Merged

doc: clarify optional cloudtrail_sns region requirement #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/organizational/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ variable "organizational_member_default_admin_role" {
variable "cloudtrail_sns_arn" {
type = string
default = "create"
description = "ARN of a pre-existing cloudtrail_sns. Used together with `cloudtrail_sns_arn`, `cloudtrail_s3_arn`. If it does not exist, it will be inferred from created cloudtrail. Providing an ARN requires permisision to SNS:Subscribe, check ./modules/infrastructure/cloudtrail/sns_permissions.tf block"
description = "ARN of a pre-existing cloudtrail_sns. Used together with `cloudtrail_sns_arn`, `cloudtrail_s3_arn`. If it does not exist, it will be inferred from created cloudtrail. Providing an ARN requires permission to SNS:Subscribe, check ./modules/infrastructure/cloudtrail/sns_permissions.tf block"
}

variable "cloudtrail_s3_arn" {
Expand Down
2 changes: 1 addition & 1 deletion examples/single-account-k8s/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
variable "cloudtrail_sns_arn" {
type = string
default = "create"
description = "ARN of a pre-existing cloudtrail_sns. If it does not exist, it will be inferred from created cloudtrail"
description = "ARN of a pre-existing cloudtrail_sns. If defaulted, a new cloudtrail will be created. If specified, deployment region must match Cloudtrail S3 bucket region"
}

variable "cloudtrail_is_multi_region_trail" {
Expand Down
2 changes: 1 addition & 1 deletion examples/single-account/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
variable "cloudtrail_sns_arn" {
type = string
default = "create"
description = "ARN of a pre-existing cloudtrail_sns. If defaulted, a new cloudtrail will be created"
description = "ARN of a pre-existing cloudtrail_sns. If defaulted, a new cloudtrail will be created. If specified, deployment region must match Cloudtrail S3 bucket region"
}

variable "cloudtrail_is_multi_region_trail" {
Expand Down
2 changes: 1 addition & 1 deletion modules/services/cloud-connector/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ variable "ecs_vpc_subnets_private_ids" {

variable "sns_topic_arn" {
type = string
description = "ARN of a cloudtrail-sns topic"
description = "ARN of a cloudtrail-sns topic. If specified, deployment region must match Cloudtrail S3 bucket region"
}


Expand Down