Skip to content

fix: Wrong telemetry parameter for ECS #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2022
Merged

fix: Wrong telemetry parameter for ECS #80

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f07c6e1
fix: wrong parameter
hayk99 Apr 1, 2022
d7ee96e
chore: fix precommit
hayk99 Apr 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 20 additions & 12 deletions modules/services/cloud-connector/ecs-service.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,12 @@ resource "aws_ecs_task_definition" "task_definition" {
family = var.name
requires_compatibilities = ["FARGATE"]
network_mode = "awsvpc"
execution_role_arn = aws_iam_role.execution.arn # ARN of the task execution role that the Amazon ECS container agent and the Docker daemon can assume
task_role_arn = local.ecs_task_role_arn # ARN of IAM role that allows your Amazon ECS container task to make calls to other AWS services.
cpu = var.ecs_task_cpu
memory = var.ecs_task_memory
execution_role_arn = aws_iam_role.execution.arn
# ARN of the task execution role that the Amazon ECS container agent and the Docker daemon can assume
task_role_arn = local.ecs_task_role_arn
# ARN of IAM role that allows your Amazon ECS container task to make calls to other AWS services.
cpu = var.ecs_task_cpu
memory = var.ecs_task_memory

container_definitions = jsonencode([
{
Expand All @@ -39,9 +41,11 @@ resource "aws_ecs_task_definition" "task_definition" {
valueFrom = var.secure_api_token_secret_name
}
]
portMappings = [{
containerPort = 5000
}]
portMappings = [
{
containerPort = 5000
}
]
logConfiguration = {
logDriver = "awslogs"
options = {
Expand All @@ -64,7 +68,7 @@ locals {
value = tostring(local.verify_ssl)
},
{
name = "telemetryDeploymentMethod"
name = "TELEMETRY_DEPLOYMENT_METHOD"
value = "terraform_aws_ecs_${local.suffix_org}"
},
{
Expand All @@ -75,9 +79,13 @@ locals {
name = "SECURE_URL",
value = data.sysdig_secure_connection.current.secure_url
}
], flatten([for env_key, env_value in var.extra_env_vars : [{
name = env_key,
value = env_value
}]])
], flatten([
for env_key, env_value in var.extra_env_vars : [
{
name = env_key,
value = env_value
}
]
])
)
}