Skip to content

feat: enable ecr/ecs scanning optionals #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 10, 2022
Merged

feat: enable ecr/ecs scanning optionals #61

merged 10 commits into from
Feb 10, 2022

Conversation

wideawakening
Copy link
Contributor

@wideawakening wideawakening commented Feb 8, 2022 •
edited
Loading

new input variables: deploy_image_scanning_ecr and deploy_image_scanning_ecs

in examples

  • org
  • single
  • single-k8s

and required submodules

  • cloud-connector

check from contribution guidelines

  • input/output variables have been modified?
    • terraform-docs has been updated accordingly
    • if these inputs are mandatory, they've been changed on
      they're not mandatory, by default deploy_immage_scanning_[ecr, ecs] are defaulted to true

@wideawakening wideawakening marked this pull request as ready for review February 9, 2022 18:34
@wideawakening wideawakening merged commit f963830 into master Feb 10, 2022
@wideawakening wideawakening deleted the feat/organizational-scanning-optional branch February 10, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wideawakening