Skip to content

fix: honour cloudtrail_kms_enable on resource creation #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2021
Merged

fix: honour cloudtrail_kms_enable on resource creation #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions modules/infrastructure/cloudtrail/kms.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,19 @@
resource "aws_kms_alias" "kms" {
target_key_id = aws_kms_key.cloudtrail_kms.id
name = "alias/${var.name}"
}


resource "aws_kms_key" "cloudtrail_kms" {
count = var.cloudtrail_kms_enable ? 1 : 0
is_enabled = true
enable_key_rotation = true
policy = data.aws_iam_policy_document.cloudtrail_kms.json
policy = data.aws_iam_policy_document.cloudtrail_kms[0].json
tags = var.tags
}

resource "aws_kms_alias" "kms" {
count = var.cloudtrail_kms_enable ? 1 : 0
target_key_id = aws_kms_key.cloudtrail_kms[0].id
name = "alias/${var.name}"
}

data "aws_iam_policy_document" "cloudtrail_kms" {
count = var.cloudtrail_kms_enable ? 1 : 0
statement {
sid = "Enable IAM User Permissions"
effect = "Allow"
Expand Down
2 changes: 1 addition & 1 deletion modules/infrastructure/cloudtrail/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ resource "aws_cloudtrail" "cloudtrail" {
s3_bucket_name = aws_s3_bucket.cloudtrail.id
is_multi_region_trail = var.is_multi_region_trail

kms_key_id = var.cloudtrail_kms_enable ? aws_kms_key.cloudtrail_kms.arn : null
kms_key_id = var.cloudtrail_kms_enable ? aws_kms_key.cloudtrail_kms[0].arn : null
sns_topic_name = aws_sns_topic.cloudtrail.id

enable_logging = true
Expand Down