Skip to content

feat: Propagate ECS Service tags to tasks #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: Propagate ECS Service tags to tasks #177

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7354db9
feat: Propagate ECS Service tags to tasks
nkraemer-sysdig Jun 27, 2023
3fff44d
Merge branch 'master' into feat/propagate-ecs-tags
Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/services/cloud-connector-ecs/ecs-service.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ resource "aws_ecs_service" "service" {
task_definition = aws_ecs_task_definition.task_definition.arn
wait_for_steady_state = true
tags = var.tags
propagate_tags = "SERVICE"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about ServiceFamily too?

Copy link
Contributor Author

@nkraemer-sysdig nkraemer-sysdig Jun 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AWS Terraform provider currently only supports propagation of tags from either the SERVICE or TASK_DEFINITION: https://registry.terraform.io/providers/hashicorp/aws/5.0.1/docs/resources/ecs_service#propagate_tags


lifecycle {
ignore_changes = [desired_count]
Expand Down