Skip to content

Allow dashboards created with API v1 to be uploaded to API v2 #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Apr 11, 2019

Conversation

davideschiera
Copy link
Contributor

Use case: You created a dashboard backup with dashboards API v1. You now have the Sysdig API with dashboards v2. The Python library will convert the v1 dashboard to the v2 format.

@davideschiera davideschiera self-assigned this Apr 1, 2019
@davideschiera davideschiera changed the base branch from master to dashboards-api-v2 April 1, 2019 22:57
sdclient.delete_dashboard(res['dashboard'])
else:
print('=====')
print(res)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should include the dashboard ID at this message. Otherwise the user won't be able to recognise which dashboard had a problem.

@davideschiera davideschiera merged commit f98d049 into dashboards-api-v2 Apr 11, 2019
davideschiera added a commit that referenced this pull request Apr 11, 2019
@davideschiera davideschiera deleted the dashboard-convert-v1-to-v2 branch April 12, 2019 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants