Fix dashboard create (copy, from file) #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
davideschiera
commented
Jan 9, 2019
davideschiera
commented
- Scope is expected to be a string (no longer an object)
- Public sharing is disabled
- Old grouping configuration and scope support removed
- Patch dashboard format to fix UI custom scope warning
1. Scope is expected to be a string (no longer an object) 2. Public sharing is disabled 3. Old grouping configuration and scope support removed 4. Patch dashboard format to fix UI custom scope warning
nagsubram
reviewed
Jan 10, 2019
| for sentry in scope: | ||
| baseconfid = baseconfid + str(list(sentry.keys())[0]) | ||
| baseconfid = baseconfid + str(list(sentry.values())[0]) | ||
| def create_dashboard_from_template(self, dashboard_name, template, scope, shared=False, annotations={}): |
There was a problem hiding this comment.
don't we need the scope validation logic anymore?
There was a problem hiding this comment.
If you look at the old code, it seems that the logic assumes that the scope string is always a list of anded expressions, each with = operator. Also, the logic was then applied to use the obsolete JSON structure for the filter.
I trust the backend validation more than this obsolete logic.
|
@nagsubram @alexgallotta how does this PR look? Thanks! |
nagsubram
approved these changes
Jan 11, 2019
|
If I'm not mistaken, the function I changed is used by 3 API functions: I tested the one used by the example "copy dashboard", and it was working properly. I expect the other 2 functions to work fine as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.