Fix tests for events #33
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging an unrelated enhancement, the Travis run showed the
delete_event
example failed. I traced it down to an event in the backend that's failing delete reasons yet to be explained (event ID=413658984227033090). However, it was an event that shouldn't have been flagged bydelete_event
in the first place. That is, thepost_event
examples were creating events with names "test event name" anddelete_event
was targeting all events with name "test event". However, I think due to the way ES search works, this was actually matching all items with names matching test OR event, which is why it was finding this rogue/unrelated event that wouldn't delete. I've now tightened all of this up by using underscores to make single-token names "test_event_name", so that way the examples will only create/delete their own stuff.