Skip to content

Fix tests for events #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2017
Merged

Fix tests for events #33

merged 1 commit into from
May 30, 2017

Conversation

philrz
Copy link
Contributor

@philrz philrz commented May 30, 2017

After merging an unrelated enhancement, the Travis run showed the delete_event example failed. I traced it down to an event in the backend that's failing delete reasons yet to be explained (event ID=413658984227033090). However, it was an event that shouldn't have been flagged by delete_event in the first place. That is, the post_event examples were creating events with names "test event name" and delete_event was targeting all events with name "test event". However, I think due to the way ES search works, this was actually matching all items with names matching test OR event, which is why it was finding this rogue/unrelated event that wouldn't delete. I've now tightened all of this up by using underscores to make single-token names "test_event_name", so that way the examples will only create/delete their own stuff.

@philrz philrz merged commit c2609e1 into master May 30, 2017
@philrz philrz deleted the fix-events-tests branch May 30, 2017 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant