Skip to content

Use Slack notification name field instead of channel. #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2020

Conversation

iris-garcia
Copy link
Contributor

Sysdig REST API returns Slack channel name as response['name'] instead of response['options']['channel'] (which is empty):

Example of curl GET (/api/notificationChannels)

{"notificationChannels":[{"id":865,"version":1,"createdOn":1602011148000,"modifiedOn":1602011148000,"teamId":1111,"type":"SLACK","enabled":true,"sendTestNotification":false,"name":"#channel","options":{"notifyOnOk":true,"url":"https://this-is-a-test.ok/123","channel":"","notifyOnResolve":true}}

image

Integrating this pull request, it would be possible to filter Slack notification channels by using the name field, currently it is not possible to filter by channel name.

@tembleking
Copy link
Member

Hi @iris-garcia, thanks for your contribution. As I mentioned in #149, secrets are not mounted into PRs from forked repositories. That's a known limitation in GitHub Actions.
We will review and test this PR.

@tembleking tembleking merged commit e22f3b9 into sysdiglabs:master Oct 26, 2020
@tembleking
Copy link
Member

Hey Iris, I am merging this, thanks for your contribution! 💯

tembleking pushed a commit that referenced this pull request Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants