Skip to content

feat(json): serialize None as null, close #622 #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2022
Merged

feat(json): serialize None as null, close #622 #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/syrupy/extensions/json/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def _filter(
elif matcher:
data = matcher(data=data, path=path)

if isinstance(data, (int, float, str)):
if isinstance(data, (int, float, str)) or data is None:
return data

filtered_dct: Dict[Any, Any]
Expand Down
2 changes: 1 addition & 1 deletion ...tensions/json/__snapshots__/test_json_filters/test_exclude_in_json_with_empty_values.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"empty_dict": {},
"empty_list": [],
"none": "None"
"none": null
}
2 changes: 1 addition & 1 deletion tests/syrupy/extensions/json/__snapshots__/test_json_filters/test_serializer[content2].json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
"datetime": "2021-01-31T23:59:00.000000",
"float": 4.2,
"int": -1,
"null": "None",
"null": null,
"str": "foo"
}
1 change: 1 addition & 0 deletions tests/syrupy/extensions/json/__snapshots__/test_json_serializer/test_dict[actual2].json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"a": "Some ttext.",
"key": null,
"multi\nline\nkey": "Some morre text."
}
2 changes: 1 addition & 1 deletion tests/syrupy/extensions/json/__snapshots__/test_json_serializer/test_empty_snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
"None"
null
1 change: 1 addition & 0 deletions tests/syrupy/extensions/json/test_json_serializer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ def test_set(snapshot_json, actual):
"multi\nline\nkey": "Some morre text.",
frozenset({"1", "2"}): ["1", 2],
ExampleTuple(a=1, b=2, c=3, d=4): {"e": False},
"key": None,
},
{},
{"key": ["line1\nline2"]},
Expand Down