Skip to content

chore: remove ABC from SnapshotComparator #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2022
Merged

chore: remove ABC from SnapshotComparator #671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/syrupy/extensions/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,16 +183,16 @@ def delete_snapshots(
"""
raise NotImplementedError

def _pre_read(self, *, index: "SnapshotIndex" = 0) -> None:
def _pre_read(self, *, index: "SnapshotIndex" = 0) -> None: # noqa: B027
pass

def _post_read(self, *, index: "SnapshotIndex" = 0) -> None:
def _post_read(self, *, index: "SnapshotIndex" = 0) -> None: # noqa: B027
pass

def _pre_write(self, *, data: "SerializedData", index: "SnapshotIndex" = 0) -> None:
self.__ensure_snapshot_dir(index=index)

def _post_write(
def _post_write( # noqa: B027
self, *, data: "SerializedData", index: "SnapshotIndex" = 0
) -> None:
pass
Expand Down Expand Up @@ -390,7 +390,7 @@ def __strip_ends(self, line: str) -> str:
return line.rstrip("".join(self._ends.keys()))


class SnapshotComparator(ABC):
class SnapshotComparator:
def matches(
self,
*,
Expand Down