Skip to content

Bug fix: Add optional chain for inTable check #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jeremyjacob
Copy link

@jeremyjacob jeremyjacob commented Dec 9, 2024

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and discussions and couldn’t find anything or linked relevant results below
  • I made sure the docs are up to date
  • I included tests (or that’s not needed)

Description of changes

Add optional chain in exitCodeText this.data.inTable check because this.data is sometimes undefined. I will admit I have not pulled the thread on why this.data is sometimes undefined. This is likely a problem higher up the food chain (in my case Vinxi build (with SolidStart) -> solid-jsx -> MDX so I understand if it is not desirable to include this change here. Nonetheless, it would be nice to have this fail without halting the entire build process as everything else appears to be working fine. Currently I am monkey-patching this character in to achieve successful builds.

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Dec 9, 2024

This comment has been minimized.

@wooorm
Copy link
Member

wooorm commented Dec 13, 2024

Hi! This is something that was added in a major. These majors have bubbled through the ecosystem. Therefore, it is likely that you have mismatched versions. I have no clue what Vinxi build is, maybe it’s old. Please make sure everything is up to date. And if it is and still doesn’t work, narrow it down. Perhaps raise an issue with Vinxi!

@wooorm wooorm closed this Dec 13, 2024
@wooorm wooorm added the 🙅 no/wontfix This is not (enough of) an issue for this project label Dec 13, 2024

This comment has been minimized.

@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙅 no/wontfix This is not (enough of) an issue for this project 👎 phase/no Post cannot or will not be acted on
Development

Successfully merging this pull request may close these issues.

2 participants