Skip to content

Conversation

@Methuselah96
Copy link
Contributor

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Fix these type errors:

ERROR in ../../.yarn/cache/mdast-util-gfm-table-npm-1.0.3-e785b8b0a4-f310f06a57.zip/node_modules/mdast-util-gfm-table/index.d.ts 10:32-39
TS2307: Cannot find module 'mdast' or its corresponding type declarations.
     8 | /** @type {FromMarkdownExtension} */
     9 | export const gfmTableFromMarkdown: FromMarkdownExtension
  > 10 | export type AlignType = import('mdast').AlignType
       |                                ^^^^^^^
    11 | export type Table = import('mdast').Table
    12 | export type TableRow = import('mdast').TableRow
    13 | export type TableCell = import('mdast').TableCell

ERROR in ../../.yarn/cache/mdast-util-gfm-table-npm-1.0.3-e785b8b0a4-f310f06a57.zip/node_modules/mdast-util-gfm-table/index.d.ts 11:28-35
TS2307: Cannot find module 'mdast' or its corresponding type declarations.
     9 | export const gfmTableFromMarkdown: FromMarkdownExtension
    10 | export type AlignType = import('mdast').AlignType
  > 11 | export type Table = import('mdast').Table
       |                            ^^^^^^^
    12 | export type TableRow = import('mdast').TableRow
    13 | export type TableCell = import('mdast').TableCell
    14 | export type InlineCode = import('mdast').InlineCode

ERROR in ../../.yarn/cache/mdast-util-gfm-table-npm-1.0.3-e785b8b0a4-f310f06a57.zip/node_modules/mdast-util-gfm-table/index.d.ts 12:31-38
TS2307: Cannot find module 'mdast' or its corresponding type declarations.
    10 | export type AlignType = import('mdast').AlignType
    11 | export type Table = import('mdast').Table
  > 12 | export type TableRow = import('mdast').TableRow
       |                               ^^^^^^^
    13 | export type TableCell = import('mdast').TableCell
    14 | export type InlineCode = import('mdast').InlineCode
    15 | export type MarkdownTableOptions = import('markdown-table').MarkdownTableOptions

ERROR in ../../.yarn/cache/mdast-util-gfm-table-npm-1.0.3-e785b8b0a4-f310f06a57.zip/node_modules/mdast-util-gfm-table/index.d.ts 13:32-39
TS2307: Cannot find module 'mdast' or its corresponding type declarations.
    11 | export type Table = import('mdast').Table
    12 | export type TableRow = import('mdast').TableRow
  > 13 | export type TableCell = import('mdast').TableCell
       |                                ^^^^^^^
    14 | export type InlineCode = import('mdast').InlineCode
    15 | export type MarkdownTableOptions = import('markdown-table').MarkdownTableOptions
    16 | export type FromMarkdownExtension = import('mdast-util-from-markdown').Extension

ERROR in ../../.yarn/cache/mdast-util-gfm-table-npm-1.0.3-e785b8b0a4-f310f06a57.zip/node_modules/mdast-util-gfm-table/index.d.ts 14:33-40
TS2307: Cannot find module 'mdast' or its corresponding type declarations.
    12 | export type TableRow = import('mdast').TableRow
    13 | export type TableCell = import('mdast').TableCell
  > 14 | export type InlineCode = import('mdast').InlineCode
       |                                 ^^^^^^^
    15 | export type MarkdownTableOptions = import('markdown-table').MarkdownTableOptions
    16 | export type FromMarkdownExtension = import('mdast-util-from-markdown').Extension
    17 | export type FromMarkdownHandle = import('mdast-util-from-markdown').Handle

ERROR in ../../.yarn/cache/mdast-util-gfm-table-npm-1.0.3-e785b8b0a4-f310f06a57.zip/node_modules/mdast-util-gfm-table/index.d.ts 16:44-70
TS2307: Cannot find module 'mdast-util-from-markdown' or its corresponding type declarations.
    14 | export type InlineCode = import('mdast').InlineCode
    15 | export type MarkdownTableOptions = import('markdown-table').MarkdownTableOptions
  > 16 | export type FromMarkdownExtension = import('mdast-util-from-markdown').Extension
       |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^
    17 | export type FromMarkdownHandle = import('mdast-util-from-markdown').Handle
    18 | export type ToMarkdownExtension = import('mdast-util-to-markdown').Options
    19 | export type ToMarkdownHandle = import('mdast-util-to-markdown').Handle

ERROR in ../../.yarn/cache/mdast-util-gfm-table-npm-1.0.3-e785b8b0a4-f310f06a57.zip/node_modules/mdast-util-gfm-table/index.d.ts 17:41-67
TS2307: Cannot find module 'mdast-util-from-markdown' or its corresponding type declarations.
    15 | export type MarkdownTableOptions = import('markdown-table').MarkdownTableOptions
    16 | export type FromMarkdownExtension = import('mdast-util-from-markdown').Extension
  > 17 | export type FromMarkdownHandle = import('mdast-util-from-markdown').Handle
       |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^
    18 | export type ToMarkdownExtension = import('mdast-util-to-markdown').Options
    19 | export type ToMarkdownHandle = import('mdast-util-to-markdown').Handle
    20 | export type ToMarkdownContext = import('mdast-util-to-markdown').Context

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Mar 14, 2022
@wooorm
Copy link
Member

wooorm commented Mar 14, 2022

@wooorm
Copy link
Member

wooorm commented Mar 15, 2022

  • AlignType and Table are not supposed to be exported, hence lib/ mentioned in the other PR here is needed instead of adding @types/mdast
  • FromMarkdownExtension is supposed to be used in the export, so that change is correct

@wooorm wooorm closed this Mar 15, 2022
@wooorm wooorm reopened this Mar 15, 2022
@github-actions

This comment was marked as resolved.

@wooorm wooorm changed the title Add packages that types depend on to dependencies Add missing dependency for types Mar 15, 2022
@wooorm wooorm merged commit 30940db into syntax-tree:main Mar 15, 2022
@Methuselah96 Methuselah96 deleted the fix-type-dependencies branch March 15, 2022 13:53
@wooorm
Copy link
Member

wooorm commented Mar 15, 2022

Released!

@wooorm wooorm added the 💪 phase/solved Post is done label Mar 15, 2022
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Mar 15, 2022
@Methuselah96 Methuselah96 mentioned this pull request Sep 12, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💪 phase/solved Post is done

Development

Successfully merging this pull request may close these issues.

2 participants