Skip to content

Ignored null values in element position #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Ignored null values in element position #12

wants to merge 1 commit into from

Conversation

danielepolencic
Copy link

Closes #11

@ChristianMurphy ChristianMurphy requested a review from a team August 1, 2020 12:39
@wooorm
Copy link
Member

wooorm commented Aug 21, 2020

Can you clarify how to reproduce this problem? I saw the HTML in the linked issue, but checking w/ ASTExplorer, it seems all positional information is there.
I’m thinking that this isn’t the root of the problem, that something else is going wrong, so that this change hides instead of fixes a problem?

@danielepolencic
Copy link
Author

Updated the gist with the code to reproduce the issue: https://gist.github.com/danielepolencic/67013b543f1938858aa68c41095b2156

@wooorm
Copy link
Member

wooorm commented Aug 23, 2020

Thanks! Apparently positional information failed, specifically with template elements. Fixed!

@wooorm wooorm added the 👀 no/external This makes more sense somewhere else label Aug 23, 2020
@danielepolencic
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
👀 no/external This makes more sense somewhere else
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot read property 'end' of null
2 participants
@danielepolencic @wooorm