Event approach: clean up API error handling with concise user messages #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tareqas
force-pushed
the
handler
branch
2 times, most recently
from
242b210 to
5cd82df
Compare
| $output->writeln('<error>Something went wrong. Please try again.</error>'); | ||
| } | ||
|
|
||
| $event->setExitCode(0); |
There was a problem hiding this comment.
It will terminate the process gracefully and display only a user-friendly message. No exception details or additional output.
There was a problem hiding this comment.
correct, but is that what ppl will expect? I'm not sure
There was a problem hiding this comment.
exit code is 0
➜ insight git:(handler) ✗ bin/insight analyze 1c92dfd89776
Something went wrong. Please try again, or run with -v for more details.exit code 1
➜ insight git:(handler) ✗ bin/insight analyze 1c92dfd89776
Something went wrong. Please try again, or run with -v for more details.
In AnalyzeCommand.php line 43:
Testing the exception handling
analyze [--format FORMAT] [--reference REFERENCE] [--branch BRANCH] [--show-ignored-violations] [--poll-period POLL-PERIOD] [--fail-condition FAIL-CONDITION] [--no-wait] [--] <project-uuid>There was a problem hiding this comment.
This doesn't make sense. Optimizing the displayed output shouldn't come at the price of breaking exit codes. Can you figure out another way that doesn't break the exit code?
nicolas-grekas
force-pushed
the
handler
branch
from
268c80b to
206578a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.